Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix location of LICENSE.md file in Repo #82

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Fix location of LICENSE.md file in Repo #82

merged 4 commits into from
Aug 14, 2019

Conversation

crweiner
Copy link
Contributor

@crweiner crweiner commented Oct 25, 2018 •
edited
Loading

Just as in the other PR's below, this PR fixes links to your README.md file so the link is correct to your MIT License. 👍

Similar to:

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Fixes link in README.md to the license file, which is proparly located at LICENSE.md not LICENSE.txt

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 25, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 25, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@crweiner
Copy link
Contributor Author

I have also just pushed commits to update the location of the LICENSE.md file in the following locations:

csharp-http-client/nuspec/SendGrid.CSharp.HTTP.Client.3.3.0.nuspec

Line 8 in 3164990

<licenseUrl>https://github.com/sendgrid/csharp-http-client/blob/master/LICENSE</licenseUrl>

csharp-http-client/UnitTest/UnitTest.cs

Line 107 in 3164990

var licensePath = Path.Combine("..", "..", "..", "LICENSE.txt");

csharp-http-client/README.md

Line 5 in 67a0569

[![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](./LICENSE.txt)

This will hopefully fix one of the Travis errors: https://travis-ci.org/sendgrid/csharp-http-client/builds/446382440#L1724

@crweiner crweiner changed the title Fix Link to LICENSE.md in README.md Fix location of LICENSE.md file in Repo Oct 26, 2018
@crweiner
Copy link
Contributor Author

Good news, this change does now seem to get the Travis build to pass! 😄 👍

https://travis-ci.org/sendgrid/csharp-http-client/builds/446750111

The last successful Travis build of master was about a year ago here.

That's a +1 for having simple changes solve big problems. 😅

@crweiner
Copy link
Contributor Author

crweiner commented Oct 26, 2018 •
edited
Loading

I just saw that @AnnaDodson also has a fix for UnitTest.cs in PR #77 and Issue #76. 👍 Yay for synergy! 😄

Once her PR gets merged to fix Travis, then the location of the LICENSE.md file will still need to be changed in the README.md and SendGrid.CSharp.HTTP.Client.3.3.0.nuspec which should be taken care of by this PR.

csharp-http-client/nuspec/SendGrid.CSharp.HTTP.Client.3.3.0.nuspec

Line 8 in 3164990

<licenseUrl>https://github.com/sendgrid/csharp-http-client/blob/master/LICENSE</licenseUrl>

@crweiner crweiner mentioned this pull request Apr 17, 2019
Merged
6 tasks
@thinkingserious thinkingserious merged commit c47019b into sendgrid:master Aug 14, 2019
@thinkingserious
Copy link
Contributor

Hello @crweiner,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crweiner @SendGridDX @thinkingserious